Skip to content

Fix positionMillis() #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pr8x wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix positionMillis() #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c40a936
Update codecs.h
pr8x Apr 23, 2023
abc43a1
Update codecs.cpp
pr8x Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codecs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ bool AudioCodec::pause(const bool paused)
/** from Fat16util.h 2008 by William Greiman**/
int AudioCodec::freeRam(void) {
extern int __bss_end;
extern int* __brkval;
extern char* __brkval;
int free_memory;
if (reinterpret_cast<int>(__brkval) == 0) {
// if no heap use from end of bss section
Expand Down
2 changes: 1 addition & 1 deletion codecs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class AudioCodec : public AudioStream, protected CodecFile
AudioCodec(void) : AudioStream(0, NULL) {initVars();}
bool pause(const bool paused);
bool isPlaying(void) {return playing > 0;}
unsigned positionMillis(void) { return (AUDIO_SAMPLE_RATE_EXACT / 1000) * samples_played;}
unsigned positionMillis(void) { return (samples_played / AUDIO_SAMPLE_RATE_EXACT) * 1000;}
unsigned lengthMillis(void) {return max(fsize() / (bitrate / 8 ) * 1000, positionMillis());} //Ignores VBR
int channels(void) {return _channels;}
int bitRate(void) {return bitrate;}
Expand Down