-
Notifications
You must be signed in to change notification settings - Fork 18
Add alternative emulation through unicorn engine #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ks0777
wants to merge
28
commits into
Fraunhofer-AISEC:master
Choose a base branch
from
ks0777:unicorn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
631f56e
add full memory and memory map dump option to faultplugin
ks0777 331f918
dump full memory state after pregoldenrun and pass to unicorn worker
ks0777 2e84241
add unicorn emulation worker with meminfo logging and pregoldenrun
ks0777 5b41bd4
implement fault types
ks0777 5ea4e69
implement fault lifetimes
ks0777 90cf5b5
add endpoint logging
ks0777 a1ac90e
add tbinfo logs
ks0777 b509af9
add tbexec logs
ks0777 b32f39e
filter tbexec/tbinfo entries
ks0777 d7a7eb0
add memory and arm/riscv register dumps
ks0777 575b61c
dump pregoldenrun memory map; handle registerdumps
ks0777 9757fa8
add logging framework
ks0777 244c641
remove modified tbs from cache during emulation
ks0777 0c316e2
fix emulation_worker
ks0777 e721d76
read pregoldenrun from backup
ks0777 9e8b023
fix log entry in gitignore
ks0777 868eee0
include basic unicorn tests in ci pipeline
ks0777 9b09415
update python dependencies
ks0777 cfdf338
fix register table selection for riscv
ks0777 c11682f
fix dead link
ks0777 6122c8e
undo stm32-timeout-wfi run.sh changes
ks0777 f818272
remove unused variable
ks0777 3264dba
remove unused workflow
ks0777 1f3bad9
controller.py: remove print; remove duplicate engine_output definitio…
ks0777 a74f941
controller.py: only parse pregoldenrun backup in unicorn mode
ks0777 8839c34
faultclass.py: remove unnecessary return
ks0777 1b8dc35
goldenrun.py: fix exception for configs without start address
ks0777 7cffe59
add aarch64 support to unicorn emulation
ks0777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # ARCHIE specific debug files | ||
| *.hdf5 | ||
| log_* | ||
| log*.txt | ||
|
|
||
| # C | ||
| ## Prerequisites | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the advantage of this, can we just leave it in the build dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't directly import the .so if its directory is not in the PATH. An alternative would be to add the build directory to the path before importing the .so in faultclass.py. This is easily done with 4 lines of code but overall not really clean either imo. With this solution, however, there would be no more copies of the .so file which might be less confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, both solutions are not perfect. Maybe the best would be to adopt the same approach we are currently using for the faultplugin. That would mean not copying the library and instead adding a new config entry to qemuconf.json for specifying its location.