Fix DateTime constructor default argument handling for macOS#69
Open
ALor79 wants to merge 1 commit intoFraunhofer-FIT-DIEN:mainfrom
Open
Fix DateTime constructor default argument handling for macOS#69ALor79 wants to merge 1 commit intoFraunhofer-FIT-DIEN:mainfrom
ALor79 wants to merge 1 commit intoFraunhofer-FIT-DIEN:mainfrom
Conversation
|
This also fixes building on Apple Silicon Macs. |
Collaborator
|
Thanks a lot for reporting this and for taking the time to investigate 👍 You’re absolutely right — this turned out to be a bug on our side, not an Apple-related issue. I’ve pushed a fix 3c7d7f0 to address the problem. It’s admittedly a bit odd that this only surfaced on macOS and not on Linux or Windows, especially since the class in question isn’t even used in v2 and is scheduled to be completely rewritten in v3. That said, it definitely shouldn’t have been a compilation blocker, so thanks again for catching it. Please pull the latest changes and let me know if you’re still seeing any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it is better to completely move the default arguments to header files as suggestted by tomas789 due to the more aggressive nature of CMake on mac. this could be an alternative that allows mac users with intel cores to already start using this library.