Add Minter module to frxUSD oft#118
Open
tom2o17 wants to merge 4 commits intoFraxFinance:feat/oft-upgrade-v1.1.1from
Open
Add Minter module to frxUSD oft#118tom2o17 wants to merge 4 commits intoFraxFinance:feat/oft-upgrade-v1.1.1from
tom2o17 wants to merge 4 commits intoFraxFinance:feat/oft-upgrade-v1.1.1from
Conversation
Collaborator
|
What if, instead of minting on remote chains, we hop to Fraxtal, mint there, and send the tokens back via hopCompose()? |
Add the minter_burn_from function as well as monotonic accounting variables
pegahcarter
reviewed
Nov 6, 2025
| /// @param minter_address Address of minter to add | ||
| function _addMinter(address minter_address) internal { | ||
| MinterModuleStorage storage $ = _getMinterModuleStorage(); | ||
| if ($.minters[minter_address]) revert AlreadyExists(); |
Collaborator
There was a problem hiding this comment.
nit: add zero-address sanity checks similar to Fraxtal's frxUSD.
pegahcarter
reviewed
Nov 6, 2025
contracts/modules/MinterModule.sol
Outdated
| // Views | ||
| //============================================================================== | ||
|
|
||
| function minters(address _address) public view returns(bool) { |
Collaborator
There was a problem hiding this comment.
nit: these views can be external if they're not called internally.
Author
There was a problem hiding this comment.
But playing devils advocate here, we do not know what cases these could be needed in the future
For example if we implement a burn module and want to gate it by minters
Collaborator
There was a problem hiding this comment.
Oh good point. I didn't think of that. Yeah in that case we would want the functions public. Okay, I am good with keeping them public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Minter Module to OFT tokens