Draft
Conversation
pegahcarter
changed the base branch from
refactor/composeMsg
to
feat/remoteSet
|
@pegahcarter please feel free to tag me here if you want our AI auditor to scan the PR for a security review. |
* refactor: RemoteHopV2 composeMsg * refactor: _sendLocal() * refactor: FraxtalHopV2 * fix: compile * revert: fee calculation * revert: fee caluclations on FraxtalHop * refactor: HopV2 with shared state * refactor: _sendLocal() * refactor: _sendToDestination() * refactor: _isTrustedHopMessage * docs: isTrustedHopMessage * refactor: _validateComposeMessage() * refactor: sendOFT() * refactor: quote() * refactor: localEid, endpoint to constructor * refactor: successful HopMessage passing * refactor: isTrustedHopMessage arg to hopCompose() * build: upgrade frax-standard-solidity * refactor: upgradeable HopV2 * fix: overwrite HopMessage from untrusted sender * refactor: include data to HopMessage * revert: hopCompose() remove _isTrustedHopMessage * fix: replay on fraxtal of failing remoteHop.lzCompose() * chore: docs * nit: doc * feat: remotely set admin funcs * feat: remotely set admin funcs * fix: only allow self-calls * chore: interfaces * feat: HopSetter * scripts: deploy hop setter * Revert "feat: remotely set admin funcs" This reverts commit 0966000. * chore: fmt * refactor: add-back access control * chore: rm warnings * ops: deploy HopV2 on arb, base * refactor: localEid to storage * fix: HopSetter receive() * fix: proxy addr instead of imp * demo: set Solana executor options * refactor: deploy checklist * refactor: AccessControlEnumerableUpgradeable * chore: fmt * refactor: amount => amountLD * fix: support oz 5.x * ops: re-deploy hops, hopSetter * feedback: @tom2o17 * feat: RemoteAdmin with Fraxtal registry (#38) * feat: RemoteAdmin with Fraxtal registry * chore: rm old hopCompose within HopV2 * chore: rm HopSetter scripts * feedback: tom2o17 * refactor: rm REMOTE_ADMIN_ROLE * chore: lint * chore: add pauser roles to msig signers * chore: lint * chore: improve RemoteAdmin docs
Collaborator
|
fraxtal-lz-hop/src/contracts/hop/ReadHop.sol Line 208 in f7c8863 Do not forget to check the the hop is actually calling the hopCompose, otherwise anybody can spoof these messages. |
Collaborator
|
fraxtal-lz-hop/src/contracts/hop/ReadHop.sol Line 229 in f7c8863 Make this a static call, otherwise somebody could spoof a readCompose callback. |
Collaborator
Author
|
It was decided internally that at this time ReadHop is not needed. Going to leave this PR open for a while in case we revisit in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a new Hop auxilliary contract that reads contract data on a target chain and returns the output data to the sender.
I added a "nonce" argument that can be passed by the caller which can be used on receipt direct the read compose to a particular action. For example, I've encoded a uint256 to be unpacked into an address, amount, and action.