Skip to content

Better gitGetVersion#1183

Open
ylecuyer wants to merge 1 commit intoFredrikNoren:masterfrom
ylecuyer:better-git-version
Open

Better gitGetVersion#1183
ylecuyer wants to merge 1 commit intoFredrikNoren:masterfrom
ylecuyer:better-git-version

Conversation

@ylecuyer
Copy link
Contributor

Check the required version from params instead of hardcoded version

@jung-kim
Copy link
Collaborator

I'm confused to how this is any better because what you are passing in isn't really a param...? it is a param created from a const in front end.

Why or how is this any better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants