Update warning message to be grammatically correct#1383
Conversation
added 2 commits
June 13, 2020 05:41
I'm unsure what the specific intent of this message is. Is it specifically saying "you may be reversing history, which could loose commits", or "you may be rewriting history, which is bad practice", both, or something else?
ghost
changed the title
The irony of this does not escape me.
Collaborator
|
It is more like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unsure what the specific intent of this message is. Is it specifically saying "you may be reversing history, which could lose commits", or "you may be rewriting history, which is bad practice", both, or something else? I ask, because it might be helpful to add a link to some git tutorial page which explains why it's bad or what could go wrong, or to make the message more specific.