Conversation
# Conflicts: # package-lock.json # package.json # scripts/build.js
campersau
reviewed
Apr 7, 2022
Contributor
|
@jung-kim is there anything here that also works on the nodegit branch where node loading and graph layout is different? |
campersau
force-pushed
the
master
branch
4 times, most recently
from
a6c34a2 to
ada40f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1091
NodeViewModel.isViewable()logic by using a map instead of doingarray.include()NodeViewModel.ref()is no longer depends onbranchesAndLocalTags()andremoteTags().graph.isBigRepo()to disable some of the featuresbranches.js's branch sortinggraph.dropareaGraphActionsto be computedCan someone test on their big repos?? It is an improvements but I'm not sure if it is enough of an improvement.
Node count matters less because we incrementally load nodes. But the over all git ref count from
show-ref -dcommand was the biggest reason for the slow down, and indirectly create nodes.This PR was tested with a repo with 14498 refs and before ungit was unusable but now it usable without any big issues now.