-
Notifications
You must be signed in to change notification settings - Fork 318
[ + ] Solar #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ + ] Solar #512
Conversation
|
FYI you didn't need to split this addition into 2 PRs. |
|
Addressing everyone involved in this PR: I am following all the recommendations requested so far. However, I am encountering some communication problems. See: Francisco-Rosa/Solar#13 Before updating the workbench to a version with Python package installation via addon manager, it is important to know how this process will occur, as it will no longer be in the current way, it is fully functional. Even more so considering that the functioning of the WB depends 100% on ladybug's Python library. I don't see why this information should be considered irrelevant, as I don't believe blindly following instructions is a good premise. We are dealing with open source, with total transparency of information. I also don't think it's appropriate, even if considered a "wrong translation", to use phrases like "Not sure how that would be relevant..." which judge whether your question deserves to be answered or not. Or the last ones, "Are you using auto-translation..." (isn't that really disrespectful?) and "You are free to study...", which are meaningless to the problem itself (there is no need to say it nor is approval expected from the person stating it). A response to these phrases using the same dynamic would be "Thank you for your help...", or something similar. These are phrases that only create noise and don't add any constructive information. When the necessary information is obtained (searching the code according to PhoneDroid's instructions), which, by the way, should be quite simple since it's about saving a path, the issue of communication "noise" will still remain, which I ask for everyone's attention to. Thank you. |
|
Merged #511 into here. |
|
|
|
@Francisco-Rosa I found a circular import issue, I've made a quickfix, not sure if that is sufficient: |
|
Author has fixed the import problem, |
|
Approved. |
No description provided.