Skip to content

Conversation

@Francisco-Rosa
Copy link
Contributor

No description provided.

@PhoneDroid
Copy link
Member

FYI you didn't need to split this addition into 2 PRs.
Reference : #511

@PhoneDroid PhoneDroid mentioned this pull request Dec 9, 2025
25 tasks
@Francisco-Rosa
Copy link
Contributor Author

Francisco-Rosa commented Jan 1, 2026

Addressing everyone involved in this PR:

I am following all the recommendations requested so far.

However, I am encountering some communication problems. See: Francisco-Rosa/Solar#13

Before updating the workbench to a version with Python package installation via addon manager, it is important to know how this process will occur, as it will no longer be in the current way, it is fully functional. Even more so considering that the functioning of the WB depends 100% on ladybug's Python library.

I don't see why this information should be considered irrelevant, as I don't believe blindly following instructions is a good premise. We are dealing with open source, with total transparency of information.

I also don't think it's appropriate, even if considered a "wrong translation", to use phrases like "Not sure how that would be relevant..." which judge whether your question deserves to be answered or not. Or the last ones, "Are you using auto-translation..." (isn't that really disrespectful?) and "You are free to study...", which are meaningless to the problem itself (there is no need to say it nor is approval expected from the person stating it).

A response to these phrases using the same dynamic would be "Thank you for your help...", or something similar. These are phrases that only create noise and don't add any constructive information.

When the necessary information is obtained (searching the code according to PhoneDroid's instructions), which, by the way, should be quite simple since it's about saving a path, the issue of communication "noise" will still remain, which I ask for everyone's attention to.

Thank you.

@PhoneDroid PhoneDroid self-assigned this Jan 16, 2026
@PhoneDroid PhoneDroid changed the title Add Solar repository to AddonCatalog.json [ + ] Solar Jan 16, 2026
@PhoneDroid PhoneDroid added the 💽 𝗔𝗱𝗱𝗼𝗻 In the context of a FreeCAD Addon. label Jan 16, 2026
@PhoneDroid PhoneDroid mentioned this pull request Jan 16, 2026
@PhoneDroid
Copy link
Member

Merged #511 into here.

@PhoneDroid PhoneDroid assigned chennes and unassigned PhoneDroid Jan 16, 2026
@PhoneDroid
Copy link
Member

PhoneDroid commented Jan 16, 2026

Approved.
Investigating import errors.

@PhoneDroid
Copy link
Member

@Francisco-Rosa I found a circular import issue,
that needs to be addressed before it can be published.

I've made a quickfix, not sure if that is sufficient:
Francisco-Rosa/Solar#16

@PhoneDroid
Copy link
Member

Author has fixed the import problem,
tested it on my setup, seems to work.

@PhoneDroid
Copy link
Member

Approved.

@chennes chennes merged commit 30ed868 into FreeCAD:master Jan 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💽 𝗔𝗱𝗱𝗼𝗻 In the context of a FreeCAD Addon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants