-
Notifications
You must be signed in to change notification settings - Fork 669
Custom type methods with examples #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
f2db4b9
be6df83
0358328
5718a8f
4830a54
396ee47
b7c0546
ca60518
660b878
625da2c
15c21b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -629,6 +629,7 @@ def to_binary(self): | |
| def from_binary(data): | ||
| obj = ExtensionObject() | ||
| obj.TypeId = NodeId.from_binary(data) | ||
| obj.Encoding = uabin.Primitives.UInt8.unpack(data) | ||
| if obj.Encoding & (1 << 0): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is that? you cannot test for the value of Encoding without first unpacking?????
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good call, I don't event remember removing that. I'm putting it back. |
||
| obj.Body = uabin.Primitives.ByteString.unpack(data) | ||
| return obj | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw that it won't work if your NamespaceIndex is not 0. I'll see what I can do to change that.