removed redundant free

czp182 · alandekok · commit 163854333262 · 2026-03-07T07:48:21.000-05:00
fclose(f) also frees oc, so talloc_free(oc) is not necessary
(lib/util/fopencookie: fix double-free of cookie in fseek error path 159)
diff --git a/src/lib/util/fopencookie.c b/src/lib/util/fopencookie.c
@@ -183,7 +183,6 @@ FILE *fopencookie(void *cookie, const char *mode, cookie_io_functions_t io_funcs
 	if (need & NEED_SEEK) {
 		if (fseek(f, 0L, SEEK_END) < 0) {
 			fclose(f);
-			talloc_free(oc);
 			return NULL;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,6 @@ FILE fopencookie(void cookie, const char *mode, cookie_io_functions_t io_funcs`
`183`	`183`	`if (need & NEED_SEEK) {`
`184`	`184`	`if (fseek(f, 0L, SEEK_END) < 0) {`
`185`	`185`	`fclose(f);`
`186`		`- talloc_free(oc);`
`187`	`186`	`return NULL;`
`188`	`187`	`}`
`189`	`188`	`}`