Conversation
topology change - update TOC in raddb to point to correct modules/files
topology changes
no kafka.adoc found. Temp remove link if it doesn’t exist
Updated nav files and repaired broken links (5)
modified internal and external links and formatted the text to be linked to url.
doc/antora/antora.yml
Outdated
| - modules/ROOT/nav.adoc | ||
| - modules/reference/nav.adoc | ||
| - modules/raddb/nav.adoc | ||
| - modules/reference/raddb/nav.adoc |
There was a problem hiding this comment.
Just drop this comment, and part of the next one where you comment this line out. Its best to just delete the line.
| *** xref:global.d/python.adoc[ldap] | ||
| *** xref:raddb/global.d/index.adoc[Global Configuration] | ||
| *** xref:raddb/global.d/ldap.adoc[ldap] | ||
| *** xref:raddb/global.d/python.adoc[python] |
There was a problem hiding this comment.
the rest of the links below this should change, too. e.g. mods-available/foo -> raddb/mods-available/foo
drop this commit, and I'll push one which fixes all of that.
| *** xref:mods-available/echo.adoc[Echo] | ||
| *** xref:mods-available/escape.adoc[Escape] | ||
| *** xref:mods-available/etc_group.adoc[etc_group] | ||
| *** xref:mods-available/exec.adoc[Exec] |
There was a problem hiding this comment.
If one of the links needs to change, then all of the other ones should be double-checked.
i.e. it's easier to do a global search and replace of xref: to xref:raddb/. This doesn't have to be done for everything in the file. But a text editor should allow you to approve or reject individual changes. in which case you can just run down the file going "yes" or "no" as needed.
| *** xref:mods-available/escape.adoc[Escape] | ||
| *** xref:mods-available/etc_group.adoc[etc_group] | ||
| *** xref:mods-available/exec.adoc[Exec] | ||
| *** xref:raddb/mods-available/always.adoc[Always] |
There was a problem hiding this comment.
I would prefer one commit for all of the changes, rather than multiple "back and forth" commits.
|
I've done a few patches myself, and then merged in a few of your commits. We prefer to avoid "back and forth" changes. Instead of making a change, undoing it, and then re-doing it, just edit the commits or squash them to make it look like you were perfect the first time. :) |
|
Close pr - global changes in scripts to update module updates/urls with new module names. Redo outstanding commits required in another PR. |
|
close |
2 participants
Updated nav files and xrefs, hyperlinks for v4 docs topology change.