Skip to content

Fix SEC_STAT.IRM bit handling in ARC SEM interrupt entry/exit #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vishwamartur wants to merge 1 commit into from
Closed

Fix SEC_STAT.IRM bit handling in ARC SEM interrupt entry/exit #1179

vishwamartur wants to merge 1 commit into from

Conversation

@vishwamartur
Copy link
Contributor

@vishwamartur vishwamartur commented Nov 1, 2024 •
edited
Loading

Related to #331

Fix the Memory Read Protection Violation from Secure MPU exception on exit from interrupt.

  • Add code to store SEC_STAT.IRM bit in INTERRUPT_PROLOGUE macro.
  • Add code to restore SEC_STAT.IRM bit in INTERRUPT_EPILOGUE macro.
  • Modify portable/ThirdParty/GCC/ARC_EM_HS/arc_support.s to include the changes in the interrupt entry/exit macros.

@vishwamartur
Fix SEC_STAT.IRM bit handling in ARC SEM interrupt entry/exit
786fdbc 
Related to FreeRTOS#331

Fix the Memory Read Protection Violation from Secure MPU exception on exit from interrupt.

* Add code to store SEC_STAT.IRM bit in INTERRUPT_PROLOGUE macro.
* Add code to restore SEC_STAT.IRM bit in INTERRUPT_EPILOGUE macro.
* Modify `portable/ThirdParty/GCC/ARC_EM_HS/arc_support.s` to include the changes in the interrupt entry/exit macros.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/FreeRTOS/FreeRTOS-Kernel/issues/331?shareId=XXXX-XXXX-XXXX-XXXX).
@vishwamartur vishwamartur requested a review from a team as a code owner November 1, 2024 16:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ActoryOu
Copy link
Member

ActoryOu commented Nov 2, 2024

Hi @vishwamartur,
Thanks for your contribution again! Could you help share your verfication result?

@aggarg
Copy link
Member

aggarg commented Nov 4, 2024

@vishwamartur Would you please share how you tested these changes?

@aggarg
Copy link
Member

aggarg commented Nov 7, 2024

@vishwamartur Would you please share the testing details.

@vishwamartur
Copy link
Contributor Author

vishwamartur commented Nov 7, 2024

Hi @ActoryOu and @aggarg,

Thank you for reviewing the PR. I haven’t yet tested the changes. I'll perform the required tests to verify the SEC_STAT.IRM bit handling in the interrupt entry/exit macros and will update the PR with the results shortly.

Please let me know if there are specific scenarios you'd like me to cover in the testing process.

Best regards,
Vishwa

@aggarg
Copy link
Member

aggarg commented Nov 12, 2024

I am closing this PR. Please open a new one when you have tested the changes.

@aggarg aggarg closed this Nov 12, 2024
moninom1 pushed a commit to moninom1/FreeRTOS-Kernel that referenced this pull request Sep 30, 2025
@chinglee-iot
Update kernel submodule to address vTaskDelete and vTaskSuspend change (
b31b3d4 
FreeRTOS#1179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishwamartur @ActoryOu @aggarg