Skip to content

Conversation

@laroche
Copy link
Contributor

@laroche laroche commented Apr 13, 2025

Remove warning message from "gcc -Wredundant-decls" in FreeRTOS_TCP_IP.c.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Remove warning message from "gcc -Wredundant-decls" in
FreeRTOS_TCP_IP.c.

Signed-off-by: Florian La Roche <[email protected]>
@laroche laroche requested a review from a team as a code owner April 13, 2025 15:52
@tony-josi-aws
Copy link
Member

Thanks @laroche for contributing to FreeRTOS+TCP. The change looks good to me.

I think it will be good to have the -Wredundant-decls option as part of our CI build checks CMakeLists.txt so that similar issues may not be added with future changes.

Do you wish to make those changes or prefer us to do so?

kar-rahul-aws
kar-rahul-aws previously approved these changes Apr 14, 2025
AhmedIsmail02
AhmedIsmail02 previously approved these changes Apr 14, 2025
@laroche
Copy link
Contributor Author

laroche commented Apr 16, 2025

Hello Tony Josi,

sounds good, please also add this tion to CI build checks.

best regards,

Florian La Roche

AhmedIsmail02
AhmedIsmail02 previously approved these changes Apr 16, 2025
tony-josi-aws
tony-josi-aws previously approved these changes Apr 16, 2025
kar-rahul-aws
kar-rahul-aws previously approved these changes Apr 16, 2025
@AhmedIsmail02
Copy link
Member

@tony-josi-aws Thanks for adding the -Wredundant-decls compiler warning option, as part of the FRI project, we've updated the formatting job to run on ubuntu v22.04 -> https://github.com/FreeRTOS/iot-reference-arm-corstone3xx/blob/bda0d25a92fea54076c8d38e82298a51f17b6ac3/.github/workflows/ci.yml#L69, would it make sense to apply this here as well?

aggarg
aggarg previously approved these changes Apr 16, 2025
@tony-josi-aws tony-josi-aws dismissed stale reviews from aggarg, kar-rahul-aws, and themself via 6813bbc April 21, 2025 07:15
@tony-josi-aws
Copy link
Member

@AhmedIsmail02

Thanks for taking a look at this PR. We have updated the CI-CD-Github-Actions repo to use uncrustify version 0.69.0 from source for Github CI hosts running the latest Ubuntu: FreeRTOS/CI-CD-Github-Actions#119
This will prevent updating the uncrustify.cfg file, which could lead to major formatting changes in other FreeRTOS repos.

@tony-josi-aws tony-josi-aws merged commit 8e437be into FreeRTOS:main Apr 21, 2025
19 of 20 checks passed
@laroche laroche deleted the lr01 branch April 27, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants