Skip to content

remove redundant function declaration #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 21, 2025
Merged

remove redundant function declaration #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37f7620
remove redundant function declaration
laroche Apr 13, 2025
c77c577
Add -Wredundant-decls to CI checks
tony-josi-aws Apr 16, 2025
28ff474
Update formatting CI check Github runnner to ubuntu-latest
tony-josi-aws Apr 16, 2025
8ff4ccf
Revert "Update formatting CI check Github runnner to ubuntu-latest"
tony-josi-aws Apr 16, 2025
4b9cbf3
Fix spell check
tony-josi-aws Apr 16, 2025
6813bbc
Revert "Revert "Update formatting CI check Github runnner to ubuntu-l…
tony-josi-aws Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/.cSpellWords.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,6 +1568,7 @@ Wpacked
Wpedantic
Wpragma
wrdata
Wredundant
Wreserved
writen
Wsign
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
exclude-dirs: source/portable/NetworkInterface/STM32

formatting:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check formatting
Expand Down
8 changes: 0 additions & 8 deletions source/FreeRTOS_TCP_IP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,6 @@
/* coverity[misra_c_2012_rule_8_9_violation] */
_static FreeRTOS_Socket_t * xSocketToListen = NULL;

#if ( ipconfigHAS_DEBUG_PRINTF != 0 )

/*
* For logging and debugging: make a string showing the TCP flags.
*/
const char * prvTCPFlagMeaning( UBaseType_t xFlags );
#endif /* ipconfigHAS_DEBUG_PRINTF != 0 */

static IPv46_Address_t xGetSourceAddrFromBuffer( const uint8_t * const pucEthernetBuffer );

/*-----------------------------------------------------------*/
Expand Down
1 change: 1 addition & 0 deletions test/build-combination/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ target_compile_options(freertos_plus_tcp
$<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Werror>
$<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wpedantic>
$<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wconversion>
$<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wredundant-decls>
$<$<COMPILE_LANG_AND_ID:C,Clang,GNU>:-Wunused-variable>
$<$<COMPILE_LANG_AND_ID:C,Clang>:-Weverything>

Expand Down