Fix possible network buffer leak DHCP v4 and v6 state machines #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazonKamath
previously approved these changes
Mar 3, 2025
ActoryOu
previously approved these changes
Mar 4, 2025
aggarg
previously approved these changes
Mar 4, 2025
tony-josi-aws
dismissed stale reviews from amazonKamath, ActoryOu, and aggarg
via
98ce576
ActoryOu
approved these changes
Mar 5, 2025
amazonKamath
approved these changes
Mar 5, 2025
lightbulbkhuang
pushed a commit
to iotlabtpe/FreeRTOS-Plus-TCP-MDNS
that referenced
this pull request
Jul 9, 2025
…TOS#1231) * Fix possible network buffer leak in DHCP v4 and v6 * DHCP v4 UT full code cov * Full code coverage DHCP v6 * Fix naming * Add UT coverage for vReleaseSinglePacketFromUDPSocket * Add UT coverage for vReleaseSinglePacketFromUDPSocket * Fix formatting * Fix compiler warning * Fix compiler warning * Fix DHCP v6 CBMC * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The zero copy UDP buffers were not freed in the DHCPv6 state machine and in a corner case for DHCPv4; those are also corrected in this PR.
Test Steps
STM32F4 - DHCP v4 tests
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.