Update IPv4 packet filtering to let packets destined to endpoint's MAC address when endpoint is not yet up #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
prvAllowIPPacketIPv4to let the packets destined to endpoint's MAC (hardware) address when endpoint is not yet up to be processed, if theipconfigETHERNET_DRIVER_FILTERS_PACKETSis disabled (default config option). This change is aligned with the RFC2131 requirement that:Since the initial DHCP
DISCOVERmessage is sent without the broadcast flag (B: BROADCAST flag) enabled, DHCP servers respond with unicastOFFERs with destination MAC address as the endpoint's MAC address. This is the preferred behavior by the RFC.Without this fix, the unicast DHCP
OFFERmessages are discarded, and the endpoint should wait till the DHCP timeout for the 2nd DHCP attempt, which is sent with the broadcast flag set to receive theOFFER/ACKmessage and complete DHCP process.Test Steps
STM32 - FreeRTOS+TCP hardware demo tests.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.