Skip to content

smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion" #1245

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5669726
smsc9220_eth_drv.c; fix warnings from "gcc -Wconversion"
laroche Apr 27, 2025
b5b0dc6
Merge branch 'main' into lr02
tony-josi-aws Apr 30, 2025
a1fbf3a
Merge branch 'main' into lr02
tony-josi-aws May 2, 2025
875feac
Merge branch 'main' into lr02
tony-josi-aws May 15, 2025
8f1f143
Add explicit cast for mac
tony-josi-aws May 16, 2025
b7331d5
Merge branch 'main' into lr02
tony-josi-aws May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/portable/NetworkInterface/MPS2_AN385/ether_lan9118/smsc9220_eth_drv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ enum smsc9220_error_t smsc9220_read_mac_address( const struct smsc9220_eth_dev_t
mac[ 0 ] = mac_low & 0xFF;
mac[ 1 ] = ( mac_low >> 8 ) & 0xFF;
mac[ 2 ] = ( mac_low >> 16 ) & 0xFF;
Copy link
Member

@kar-rahul-aws kar-rahul-aws Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the other mac indices are not typecasted to char.

Copy link
Contributor Author

@laroche laroche Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe byte ordering issues on some architectures could make a difference?

best regards,

Florian La Roche

mac[ 3 ] = ( mac_low >> 24 ) & 0xFF;
mac[ 3 ] = ( char ) ( ( mac_low >> 24 ) & 0xFF );
mac[ 4 ] = mac_high & 0xFF;
mac[ 5 ] = ( mac_high >> 8 ) & 0xFF;

Expand Down Expand Up @@ -1223,7 +1223,7 @@ uint32_t smsc9220_peek_next_packet_size( const struct
}
else
{
rx_status_from_peek = -1;
rx_status_from_peek = ( uint32_t ) -1;
}

return packet_size;
Expand Down