Move FreeRTOS_printf from suspended scheduler region in prvAcceptWaitClient #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazonKamath
approved these changes
May 13, 2025
moninom1
approved these changes
May 13, 2025
kar-rahul-aws
approved these changes
May 13, 2025
aggarg
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FreeRTOS APIs shouldn't be called while the scheduler is suspended -
vTaskSuspendAllDepending on the user implementation of
FreeRTOS_printfits highly likely that there will be blocking FreeRTOS API calls done fromFreeRTOS_printf.This PR removes the usage of
FreeRTOS_printffrom the suspended scheduler region inprvAcceptWaitClient.Thanks TDB for reporting this issue in FreeRTOS forum: https://forums.freertos.org/t/prvacceptwaitclient-gets-interrupted-with-xsemaphoretake-while-tasks-are-suspended/23056
Test Steps
Tested with a sample echo server on STM32F4
Checklist:
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
https://forums.freertos.org/t/prvacceptwaitclient-gets-interrupted-with-xsemaphoretake-while-tasks-are-suspended/23056
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.