Fix release build by guarding add_subdirectory(test)#1323
Merged
archigup merged 1 commit intoFreeRTOS:mainfrom Mar 2, 2026
Merged
Fix release build by guarding add_subdirectory(test)#1323archigup merged 1 commit intoFreeRTOS:mainfrom
archigup merged 1 commit intoFreeRTOS:mainfrom
Conversation
The release workflow removes the test/ directory from the archive before running the build command. The unconditional add_subdirectory(test) in CMakeLists.txt causes CMake to fail with: add_subdirectory given source "test" which is not an existing directory. Guard it with IS_DIRECTORY so the build succeeds when test/ is absent.
AniruddhaKanhere
approved these changes
Feb 26, 2026
kstribrnAmzn
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow fails because the
FreeRTOS/CI-CD-Github-Actions/releaseaction removes thetest/directory from the archive before running the build command (rm -rf "$ARCHIVE_DIR/test"). SinceCMakeLists.txtunconditionally callsadd_subdirectory(test), CMake fails with:Fix
Guard
add_subdirectory(test)withIS_DIRECTORYso the build succeeds whentest/is absent. No behavior change when the directory is present.