Express the need of a non-blocking TransportRecv_t#318
Merged
rohitmadan07 merged 5 commits intoFreeRTOS:mainfrom Apr 7, 2025
Merged
Express the need of a non-blocking TransportRecv_t#318rohitmadan07 merged 5 commits intoFreeRTOS:mainfrom
rohitmadan07 merged 5 commits intoFreeRTOS:mainfrom
Conversation
Member
DakshitBabbar
left a comment
There was a problem hiding this comment.
Hey @diopoex,
Thanks for this PR, looks good to me. I've added a small suggestion, let me know your thoughts.
| * mechanism can work properly. | ||
| * coreMQTT will continue to call the transport interface if it receives | ||
| * a partial packet until it accumulates enough data to get the complete | ||
| * MQTT packet. |
Member
There was a problem hiding this comment.
I was wondering if it would be better to include the fact that the user can also implement their own keep alive mechanism in which case the non-blocking receive function may/may not affect the keep alive mechanism. Something like this:
/*
* @note It is HIGHLY RECOMMENDED that the transport receive
* implementation does NOT block.
* coreMQTT will continue to call the transport interface if it receives
* a partial packet until it accumulates enough data to get the complete
* MQTT packet.
* A non‐blocking implementation is also essential so that the library's inbuilt
* keep‐alive mechanism can work properly, given the user chooses to use
* that over their own keep alive mechanism.
*/Let me know what you think.
Contributor
Author
There was a problem hiding this comment.
Yes that's perfect I think!
Co-authored-by: DakshitBabbar <100972343+DakshitBabbar@users.noreply.github.com>
Member
|
/bot run formatting |
DakshitBabbar
approved these changes
Apr 7, 2025
rohitmadan07
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Express the need of a non-blocking TransportRecv_t #317
Description
Test Steps
only changed documentation
Checklist:
Related Issue
#317
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.