Fix video pausing when saving a screenshot to the default folder#6721
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Feb 3, 2025
Merged
Fix video pausing when saving a screenshot to the default folder#6721FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 2, 2025
PikachuEXE
approved these changes
Feb 3, 2025
ChunkyProgrammer
approved these changes
Feb 3, 2025
github-actions
bot
removed
the
PR: waiting for review
doublecrow
pushed a commit
to doublecrow/FreeTube
that referenced
this pull request
Mar 28, 2025
OothecaPickle
added a commit
to OothecaPickle/FreeTube
that referenced
this pull request
Apr 29, 2025
…der (FreeTubeApp#6721)" This reverts commit 3077bea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix video pausing when saving a screenshot to the default folder
Pull Request Type
Related issue
Description
In #6636 I unified the screenshot logic in the video player, but I forgot to account for the fact that pausing is only necessary when we prompt the user for where to save the screenshot so that they don't miss what is going on in the video while they are distracted by the prompt. As saving to the default folder requires no user interaction after triggering the screenshot, we don't have to pause the video.
Testing
Desktop