Feat: Display player overlay controls on keyboard interaction #7757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
auto-merge was automatically disabled
August 9, 2025 13:20
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
PikachuEXE
reviewed
Aug 10, 2025
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
PikachuEXE
reviewed
Aug 10, 2025
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
August 10, 2025 11:45
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
August 10, 2025 11:48
Head branch was pushed to by a user without write access
|
Changes applied! |
PikachuEXE
previously approved these changes
Aug 11, 2025
kommunarr
reviewed
Aug 11, 2025
auto-merge was automatically disabled
August 12, 2025 11:31
Head branch was pushed to by a user without write access
|
Changes applied. Thanks for the suggestion! |
|
so i dug a little more into what YT does with their other keyboard shortcuts and this is what i found out: Shortcuts YT shows the player UI but FT does not (yet) Addressed by this PR:
Not addressed:
Works on YT but not useful to implement within FT
i suggest following them |
auto-merge was automatically disabled
August 13, 2025 14:08
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
August 13, 2025 14:25
Head branch was pushed to by a user without write access
Co-authored-by: absidue <[email protected]>
auto-merge was automatically disabled
September 18, 2025 11:16
Head branch was pushed to by a user without write access
caetano-dev
force-pushed
the
progressIndicator
branch
from
cdbe2cf to
4a53e12
Compare
|
Rebased. |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 19, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
kommunarr
previously approved these changes
Sep 19, 2025
PikachuEXE
requested changes
Sep 20, 2025
src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Outdated
Show resolved
Hide resolved
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
September 20, 2025 16:54
Head branch was pushed to by a user without write access
caetano-dev
dismissed stale reviews from kommunarr and efb4f5ff-1298-471a-8973-3d47447115dc
via
edfeef4
|
Changes applied. |
PikachuEXE
approved these changes
Sep 21, 2025
PikachuEXE
added
PR: waiting for review
kommunarr
approved these changes
Sep 21, 2025
absidue
approved these changes
Sep 21, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 22, 2025
* development: (24 commits) Add proxy login support (FreeTubeApp#7996) Migrate the History view to the composition API (FreeTubeApp#8064) Fix player button hiding (FreeTubeApp#8065) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Indonesian) Fix playback rate reset when video ends (FreeTubeApp#7718) Skip Electron binary download in CI as we do not run it (FreeTubeApp#8063) Feat: Display player overlay controls on keyboard interaction (FreeTubeApp#7757) Translated using Weblate (Hungarian) Translated using Weblate (Czech) Translated using Weblate (Estonian) Translated using Weblate (French) Bump electron from 37.4.0 to 38.1.0 (FreeTubeApp#8025) Translated using Weblate (Dutch) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (German) Translated using Weblate (Breton) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified Han script)) Support exporting single playlists as a list of video URLs (FreeTubeApp#8054) ... # Conflicts: # src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #7458
Description
Shows the video controls when the users interacts with the video using the keyboard, similar to YouTube.
Screenshots
video.mp4
Testing
Desktop