Skip to content

Conversation

Devenor
Copy link
Contributor

@Devenor Devenor commented Sep 7, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Adds #7049 functionality to the Tray

Description

Tray menu option enabling to open a new Freetube instance.

Screenshots

imagen

Testing

When clicking the New Window option, a new window opens. Other windows hidden in the tray must remain there.

Desktop

  • OS: Windows, Linux
  • OS Version: Windows 10, Ubuntu 22.04.3 LTS
  • FreeTube version: 0.23.8 Beta

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 7, 2025 11:21
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 7, 2025
@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 14, 2025
auto-merge was automatically disabled September 16, 2025 18:40

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 16, 2025 18:40
@Devenor
Copy link
Contributor Author

Devenor commented Sep 16, 2025

Done, but I was thinking that when the main window is hidden to the tray and there are other visible windows, none of them become the main window. Should I change that too?

@absidue absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 20, 2025
@absidue
Copy link
Member

absidue commented Sep 20, 2025

If it is easy to do, sure, if not then it would be better to leave it for a separate pull request.

auto-merge was automatically disabled September 21, 2025 19:31

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 21, 2025 19:31
@Devenor
Copy link
Contributor Author

Devenor commented Sep 21, 2025

I've added the following:

  • When all windows are hidden, the first one to be shown becomes the new main window.
  • If the main window is hidden, the one that has the focus becomes the new main window.
  • If no window has the focus (for example if they are behind another app), the last opened window becomes the new main window.

Seems to work fine. My only concern is about the timer in Linux, it works in my distro, but we might need to increase it a bit if it's not enough in others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants