Fix top nav cannot search in new window #8254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
ChunkyProgrammer,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 10, 2025
kommunarr
approved these changes
Nov 10, 2025
absidue
approved these changes
Nov 10, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 11, 2025
* development: (41 commits) Translated using Weblate (Turkish) ! Fix top nav cannot search in new window (FreeTubeApp#8254) Bump vue from 3.5.22 to 3.5.24 (FreeTubeApp#8257) Translated using Weblate (Czech) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Hungarian) Translated using Weblate (Norwegian Bokmål) Bump lefthook from 2.0.2 to 2.0.3 (FreeTubeApp#8258) Bump the eslint group with 2 updates (FreeTubeApp#8256) Bump marked from 16.4.1 to 17.0.0 (FreeTubeApp#8260) Translated using Weblate (Breton) Translated using Weblate (Estonian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified Han script)) Add support for importing and exporting search history (FreeTubeApp#8237) Invidious API: Fix published dates on recommended videos (FreeTubeApp#8251) Translated using Weblate (Chinese (Simplified Han script)) ! Fix playlist progress bar preview broken in IV API (FreeTubeApp#8245) Wrap interactive FontAwesomeIcons in actual buttons (FreeTubeApp#8206) ... # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
#8248 (review)
#8094
Description
Top nav cannot search in new window after vue 3 migration and this PR fixes it
Proxed array is returned now for
featuresand must be converted before passing it to IPC callScreenshots
Lazy
Testing
Type something in top nav and shift enter / shift click icon and ensure new window opened with search result
Desktop
Additional context