Skip to content

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc

Pull Request Type

  • Bugfix

Related issue

Closes #8474

Description

This adds an extra check in the arrow key handling so that it doesnt seek in the player anymore while trying to highlight text

Testing

  1. Load a video
  2. Double-click a word in the video's text description
  3. Press Ctrl+Shift+Left/Right Arrow to attempt to highlight more adjacent words
  4. The video wont change its playback location and will highlight the words

Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 6, 2026
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 6, 2026 15:25
@FreeTubeBot FreeTubeBot merged commit a44ea64 into FreeTubeApp:development Jan 17, 2026
6 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 17, 2026
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc deleted the fix-shift-watch-page branch January 17, 2026 12:03
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jan 19, 2026
* development: (55 commits)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Czech)
  Translated using Weblate (Russian)
  Translated using Weblate (Polish)
  Translated using Weblate (Kurdish (Central))
  Translated using Weblate (French)
  Use GITHUB_TOKEN instead of dedicated PUSH_TOKEN in auto-merge workflow (FreeTubeApp#8541)
  Local API: Implement SABR for VODs (FreeTubeApp#8047)
  Bump package version from 0.23.12 to 0.23.13 (FreeTubeApp#8531)
  Update CodeQL workflow to match the latest template (FreeTubeApp#8533)
  fix: video player playback rate (FreeTubeApp#8407)
  Decipher live DASH manifest URL (FreeTubeApp#8530)
  Add a show all windows button to the tray menu (FreeTubeApp#8494)
  Disable automatically running the flatpak workflow (FreeTubeApp#8507)
  fix using shift on watch page (FreeTubeApp#8491)
  Translated using Weblate (Hebrew)
  Translated using Weblate (Hebrew)
  Fix WAPT link in README (FreeTubeApp#8529)
  Fix typo in auto-merge workflow (FreeTubeApp#8518)
  Added translation using Weblate (Uzbek)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Ctrl+Shift+Left/Right doesnt select characters in description

5 participants