Skip to content

Conversation

@absidue
Copy link
Member

@absidue absidue commented Jan 6, 2026

Pull Request Type

  • Feature Implementation

Related issue

Description

This pull request adds a show all windows button to the tray menu, which does what it says on the tin: shows all hidden windows.

Testing

The tray menu is only implemented on Windows and Linux

  1. Enable the minimize to tray setting
  2. Open multiple windows
  3. Minimize all or most of them
  4. Click on "Show all windows" in the tray menu
  5. All windows should appear and the tray icon should disappear.

Desktop

  • OS: Windows
  • OS Version: 11

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 6, 2026
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 6, 2026 22:24
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 7, 2026

rip i cant properly test this in my Ubuntu VM due to #8359 :/
Ill try to bisect when it broke

@PikachuEXE
Copy link
Collaborator

I tested this on Windows via https://github.com/PikachuEXE/FreeTube/actions/runs/20767925766

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jan 7, 2026

Tested it too with your build and seems to be working perfectly.

I have one maybe nitpick point of discussion. My first minimized window is the last to be unminimized and my last minimized window is the first one that will show. Should we maybe change it to the other way around so the first window that is minimized is the first to show?

The current approach is very logical from the point that it was the user's last opened window to show first but i thought to raise the point anyway.

I think the current approach is good as is

@PikachuEXE
Copy link
Collaborator

I have no preference here coz I don't use it :P

@absidue
Copy link
Member Author

absidue commented Jan 8, 2026

I don't mind either way, I van reverse it if you would prefer that?

@efb4f5ff-1298-471a-8973-3d47447115dc

No i think its good but i only raised it just in case both of you wanted to see it changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add "Show All" to the tray icon menu

3 participants