-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a show all windows button to the tray menu #8494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
rip i cant properly test this in my Ubuntu VM due to #8359 :/ |
|
I tested this on Windows via https://github.com/PikachuEXE/FreeTube/actions/runs/20767925766 |
|
Tested it too with your build and seems to be working perfectly. I have one maybe nitpick point of discussion. My first minimized window is the last to be unminimized and my last minimized window is the first one that will show. Should we maybe change it to the other way around so the first window that is minimized is the first to show? The current approach is very logical from the point that it was the user's last opened window to show first but i thought to raise the point anyway. I think the current approach is good as is |
|
I have no preference here coz I don't use it :P |
|
I don't mind either way, I van reverse it if you would prefer that? |
|
No i think its good but i only raised it just in case both of you wanted to see it changed |
Pull Request Type
Related issue
Description
This pull request adds a show all windows button to the tray menu, which does what it says on the tin: shows all hidden windows.
Testing
The tray menu is only implemented on Windows and Linux
Desktop