Move shaka-player font patching into a webpack loader#8700
Merged
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom Feb 22, 2026
Merged
Move shaka-player font patching into a webpack loader#8700FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
FreeTubeBot merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
ChunkyProgrammer
approved these changes
Feb 20, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 21, 2026
PikachuEXE
approved these changes
Feb 22, 2026
Pillowytuba
pushed a commit
to Pillowytuba/FreeTube
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
I originally placed the shaka-player patching in a postinstall script as it used to patch more things (adding
export default shakato the types -> shaka-player does that itself now and downloading the google material icons font -> shaka-player now uses SVG in JS for its icons), but now that it only need to do a find-and-replace to make shaka-player reference the Roboto font that is already in this repository rather than on Google Fonts, it doesn't need to be a script anymore.In light of the Shai Hulud and Shai Hulud 2 security incidents in 2025, which along with other things, also injected malicious postinstall scripts into npm packages, people have started preventing postinstall scripts from running entirely or only allow listing specific ones. As none of the postinstall scripts that run in the FreeTube repository are essential, switching to a webpack loader will let us disable running postinstall scripts in our GitHub Actions pipelines.
Testing
rm -rf node_modules/shaka-playeryarn install --check-filesyarn run pack:renderernpx prettier@2.8.8 --no-config --write dist/renderer.*.css@font-facein thedist/renderer.*.cssfile (it should only include the one pointing to the local Roboto font)Desktop