Drop neostandard in favour of only pulling in the dev dependencies that we actually use#8724
Merged
FreeTubeBot merged 2 commits intoFreeTubeApp:developmentfrom Mar 6, 2026
Merged
Conversation
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
PR: dependencies
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Feb 28, 2026
PikachuEXE
previously approved these changes
Mar 1, 2026
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Mar 1, 2026
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
via
8f606e3
absidue
force-pushed
the
drop-neostandard
branch
from
63d06f3 to
8f606e3
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 5, 2026
ChunkyProgrammer
approved these changes
Mar 5, 2026
PikachuEXE
approved these changes
Mar 6, 2026
github-actions
bot
removed
the
PR: waiting for review
Pillowytuba
pushed a commit
to Pillowytuba/FreeTube
that referenced
this pull request
Mar 19, 2026
…at we actually use (FreeTubeApp#8724) * Drop neostandard in favour of only pulling in the dev dependencies that we actually use * Remove rules that are already listed in the @eslint/js recommended config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This pull request drops the neostandard development dependency, which pulls in a lot of development dependencies that we don't use (typescript stuff and
eslint-plugin-react's polyfill dependency hell), in favour of directly depending on the ESLint plugins that we do use@stylistic/eslint-plugin,eslint-plugin-import-x,eslint-plugin-nandeslint-plugin-promiseand copies the relevant neostandard configurations into our ESLint configuration file.I also updated the four ESLint plugins to their latest versions and updated the configs where necessary (the version of
@stylistic/eslint-pluginthat neostandard was using was quite outdated). I merged the modernizations configs directly into the base and style configs as it didn't make sense to have two configs that directly overwrite each other, I also removed the rules that are already configured identically in the@eslint/jsconfig.As an added bonus this also unblocks the ESLint dependabot updates e.g. #8717 (we will still need to deal with the breaking changes in that pull request but it will no longer error inside of outdated dependencies).
Testing
yarn installyarn eslint-lintyarn lint-jsonyarn lint-ymlDesktop