Skip to content

Handle YouTube.js 17 eval changes #8811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
absidue wants to merge 1 commit into from
Closed

Handle YouTube.js 17 eval changes #8811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions src/renderer/helpers/api/local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,9 @@ const TRACKING_PARAM_NAMES = [
]

if (process.env.SUPPORTS_LOCAL_API) {
Platform.shim.eval = (data, env) => {
Platform.shim.eval = (data) => {
return new Promise((resolve, reject) => {
const properties = []

if (env.n) {
properties.push(`n: exportedVars.nFunction("${env.n}")`)
}

if (env.sig) {
properties.push(`sig: exportedVars.sigFunction("${env.sig}")`)
}

// Triggers permission errors if we don't remove it (added by YouTube.js), as sessionStorage isn't accessible in sandboxed cross-origin iframes
const modifiedOutput = data.output.replace('const window = Object.assign({}, globalThis);', '')

const code = `${modifiedOutput}\nreturn {${properties.join(', ')}}`
const code = data.output

// Generate a unique ID, as there may be multiple eval calls going on at the same time (e.g. DASH manifest generation)
const messageId = process.env.IS_ELECTRON || crypto.randomUUID
Expand Down Expand Up @@ -108,7 +95,6 @@ async function createInnertube({ withPlayer = false, location = undefined, safet
user_agent: navigator.userAgent,

retrieve_player: !!withPlayer,
player_id: '9f4cc5e4',
location: location,
enable_safety_mode: !!safetyMode,
client_type: clientType,
Expand Down