Jc/rspec3.x upgrade

.gitignore

@@ -119,6 +119,9 @@ package-lock.json
 # local environment files
 .env.*.local
 
+# local Gemfile file
+Gemfile.local
+
 data/*
 
 .robocop.yml

.rspec

@@ -0,0 +1,3 @@
+--require spec_helper
+--format documentation
+--color

Gemfile

@@ -1,54 +1,106 @@
 source 'https://rubygems.org'
 
-gem 'rails'
-gem 'tzinfo-data' #needed by windows
-gem 'mysql2'
+# ------------------------------------------------------------
+# Core Framework
+# ------------------------------------------------------------
+gem 'rails', '5.1.7'
+
+# ------------------------------------------------------------
+# Database & ODM
+# ------------------------------------------------------------
+gem 'mongo'                    # MongoDB driver
+gem 'mongoid'                  # ODM for MongoDB
+gem 'carrierwave-mongoid', require: 'carrierwave/mongoid' # File uploads with Mongoid
+gem 'kaminari-mongoid'         # Pagination for Mongoid
+gem 'kaminari'                 # Pagination core
+
+gem 'mysql2'                   # For CMS (RefineryCMS)
+
+# ------------------------------------------------------------
+# Authentication & Authorization
+# ------------------------------------------------------------
+gem 'devise'
+gem 'devise-encryptable'
+gem 'bcrypt'
+
+# ------------------------------------------------------------
+# CMS (RefineryCMS)
+# ------------------------------------------------------------
 gem 'refinerycms'
 gem 'refinerycms-authentication-devise'
 gem 'refinerycms-wymeditor'
-# We use this version of refinerycms-i18n because of the crash in story 1831. IT MUST BE REMOVED on bump of refinery to version 5
-gem 'refinerycms-i18n', '4.0.2', git: 'https://github.com/refinery/refinerycms-i18n', ref: '30059ea'
-# See above
-gem 'mongoid'
-gem 'mongo'
-gem 'execjs'
-#gem 'libv8'
-gem 'mobvious'
-gem 'formtastic'
-#gem 'therubyracer', platforms: :ruby # avoid loading on windows
-gem 'airbrake'
-#  gem 'bcrypt', git: 'https://github.com/codahale/bcrypt-ruby'
-gem 'bcrypt'
-gem 'text'
+
+# Temporary fix: refinerycms-i18n pinned due to crash in story 1831
+# MUST BE REMOVED when upgrading Refinery to v5
+gem 'refinerycms-i18n', '4.0.2',
+    git: 'https://github.com/refinery/refinerycms-i18n',
+    ref: '30059ea'
+
+# Custom Refinery extension
+gem 'refinerycms-county_pages', path: 'vendor/extensions'
+
+# ------------------------------------------------------------
+# Frontend & Assets
+# ------------------------------------------------------------
+gem 'sass-rails'
+gem 'coffee-rails'
+gem 'bourbon'                  # Sass mixins
+gem 'font_awesome5_rails'
+gem 'jquery-rails'
+gem 'uglifier'                 # JS compressor
+
+# ------------------------------------------------------------
+# Utilities & Enhancements
+# ------------------------------------------------------------
+gem 'airbrake'                 # Error reporting
+gem 'browser'                  # Browser detection
+gem 'email_veracity'           # Email validation
+gem 'execjs'                   # JS runtime
+gem 'formtastic'               # Form builder
+gem 'geocoder', '1.3.7'        # Geocoding (locked due to regression in 1.4)
+gem 'gretel'                   # Breadcrumbs
 gem 'json'
-gem 'pry'
-gem 'pry-byebug'
-gem 'email_veracity'
-gem 'unicode'
-gem 'kaminari'
-gem 'kaminari-mongoid'
-gem 'gretel'
-gem 'geocoder', '1.3.7' #appears to be a regression in 1.4
-gem 'bourbon'
 gem 'mail-logger'
-gem 'devise'
-gem 'devise-encryptable'
-gem 'nokogiri', ">= 1.13.6"
+gem 'mobvious'                 # Mobile device detection
+gem 'newrelic_rpm'             # Performance monitoring
+gem 'nokogiri', '~> 1.15.0'
+gem 'octokit'                  # GitHub API client
 gem 'osgb', git: 'https://github.com/FreeUKGen/osgb.git'
+gem 'psych', '~> 3.3.0'
 gem 'rubyzip'
-gem 'zip-zip'
-gem 'rspec-rails'
-gem 'carrierwave-mongoid', require: 'carrierwave/mongoid'
 gem 'simple_form'
-gem 'newrelic_rpm'
-gem 'octokit'
-gem 'traceroute'
-gem 'sass-rails' #,   '~> 3.2.3'
-gem 'coffee-rails'#, '~> 3.2.1'
-gem 'uglifier'#, '>= 1.0.3'
-gem 'jquery-rails'
-gem 'font_awesome5_rails'
-gem 'refinerycms-county_pages', :path => 'vendor/extensions'
-gem 'rubocop-rails'
-gem 'rubocop', '~> 1.23.0', require: false
-gem 'browser'
+gem 'text'
+gem 'traceroute'               # Detect unused routes
+gem 'tzinfo-data'              # Required for Windows
+gem 'unicode'
+gem 'zip-zip'
+
+# ------------------------------------------------------------
+# Development & Test
+# ------------------------------------------------------------
+group :development, :test do
+  gem 'factory_bot_rails'
+  gem 'mongoid-rspec'
+  gem 'pry'
+  gem 'pry-byebug'
+  gem 'rspec-rails'
+end
+
+# ------------------------------------------------------------
+# Development Only
+# ------------------------------------------------------------
+group :development do
+  gem "puma"
+  gem 'rubocop-rails'
+end
+
+# ------------------------------------------------------------
+# Test Only
+# ------------------------------------------------------------
+group :test do
+  gem "capybara"
+end
+
+# Only load Gemfile.local if it exists
+local_gemfile = File.join(__dir__, "Gemfile.local")
+eval_gemfile(local_gemfile) if File.exist?(local_gemfile)