Open
Conversation
- adjusted code to be more readable
- added include_blank: false to each of the menu options
- freereg1_csv_files_controller.rb
- From each of the menu options removed the insert of 'Select *'
- changed UI styling
- updated page to use dropdown boxes
- javascript is present here and could be moved to a seperate file
- freereg1_csv_files_controller.rb
- added in JSON to JS to populate dropdown boxes
modified: app/views/freereg1_csv_files/_form_for_relocate.html.erb Relocate form for non-admin users and pre-select current location - Non-admin users can now see Country and County fields as read-only when accessing the relocate form. - Country, Place, and Church fields are pre-selected with the current values, enabling quick relocation between register types.
stsccfr
reviewed
Nov 27, 2025
| # Load Lists for dropdown | ||
| @countries = ['England', 'Islands', 'Scotland', 'Wales'] | ||
| @counties = ChapmanCode::CODES[@selected_country].map { |name, code| [name, code] } | ||
| #@placenames = Place.where(county: @selected_county).map { |p| [p.place_name, p.id.to_s] } |
stsccfr
reviewed
Nov 27, 2025
| if session[:selectcounty].blank? | ||
| #means we are a DM selecting the county | ||
| session[:selectcounty] = ChapmanCode::CODES[session[:selectcountry]][params[:county]] | ||
| #session[:selectcounty] = ChapmanCode::CODES[session[:selectcountry]][params[:county]] |
stsccfr
reviewed
Nov 27, 2025
| # @message_file.close if @project.type_of_project == "individual" | ||
| user = UseridDetail.where(userid: 'REGManager').first | ||
| UserMailer.update_report_to_freereg_manager(file, user).deliver_now | ||
| #UserMailer.update_report_to_freereg_manager(file, user).deliver_now |
Collaborator
There was a problem hiding this comment.
Are the changes to this file intended?
stsccfr
reviewed
Nov 27, 2025
Collaborator
There was a problem hiding this comment.
Too much code for me to review here so I will wait to test this when Vino merges it. You might consider adding some comments to help devs in future (we have been bad about not commenting the MyopicVicar code but I think we should start adding lots of comments as we figure out what this code does, because none of the original devs are with us any more).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified: app/views/freereg1_csv_files/_form_for_relocate.html.erb
Relocate form for non-admin users and pre-select current location