Skip to content

Commit 1d3e157

Browse files
committed
fix: local identifier verification
1 parent 5309452 commit 1d3e157

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

logic/background_worker.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from logic.smp import smp_unanswered_questions, smp_data_handler
33
from logic.pfs import pfs_data_handler, update_ephemeral_keys
44
from logic.message import messages_data_handler
5+
from logic.user import validate_identifier
56
from core.constants import (
67
LONGPOLL_MIN,
78
LONGPOLL_MAX,
@@ -90,15 +91,9 @@ def background_worker(user_data, user_data_lock, ui_queue, stop_flag):
9091
logger.error("Impossible condition, either you have discovered a bug in Coldwire, or the server is attempting to denial-of-service you. Skipping data message with no sender...")
9192
continue
9293

93-
if message["sender"].isdigit() and len(message["sender"]) != 16:
94-
logger.error("Impossible condition, either you have discovered a bug in Coldwire, or the server is attempting to denial-of-service you. Skipping data message with malformed same-server sender (%s)...", message["sender"])
94+
if not validate_identifier(message["sender"]):
95+
logger.error("Impossible condition, either you have discovered a bug in Coldwire, or the server is attempting to denial-of-service you. Skipping data message with malformed sender identifier (%s)...", message["sender"])
9596
continue
96-
97-
if (not message["sender"].isdigit()):
98-
split = message["sender"].split("@")
99-
if (len(split) != 2) or (not split[0].isdigit()):
100-
logger.error("Impossible condition, either you have discovered a bug in Coldwire, or the server is attempting to denial-of-service you. Skipping data message with malformed federated-server sender (%s)...", message["sender"])
101-
continue
10297

10398
sender = message["sender"]
10499
blob = message["blob"]

ui/add_contact_prompt.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def __init__(self, master):
2020
self.entry = tk.Entry(self, font=("Helvetica", 12), bg="gray15", fg="white", insertbackground="white")
2121
self.entry.pack(pady=5)
2222
self.entry.focus()
23-
enhanced_entry(self.entry, placeholder="I.e. 1234567890123456")
23+
enhanced_entry(self.entry, placeholder="I.e. 1234567890123456, [email protected]")
2424

2525
self.status = tk.Label(self, text="", fg="gray", bg="black", font=("Helvetica", 10))
2626
self.status.pack(pady=(5, 0))
@@ -62,5 +62,5 @@ def add_contact(self):
6262

6363
self.master.new_contact(contact_id)
6464
self.destroy()
65-
messagebox.showinfo("Added", "Added the user to your contact list")
65+
messagebox.showinfo("Added", f"Added the `{contact_id}` to your contact list.")
6666

0 commit comments

Comments
 (0)