Skip to content

Feature/view details issue for premium only non add-on plugin fix #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feature/view details issue for premium only non add-on plugin fix #535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4bd332
[view-details] Removed `newer_than` parameter value to get the latest…
msladu Jan 12, 2022
8d56dce
[view-details] Improved logic to make an API call when it requires.
malayladu Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions includes/class-fs-plugin-updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,8 +1079,15 @@ function plugins_api_filter( $data, $action = '', $args = null ) {
$addon_version :
$this->_fs->get_plugin_version();

// Get plugin's newest update.
$new_version = $this->get_latest_download_details( $is_addon ? $addon->id : false, $plugin_version );
// Get plugin's newest update. If it's a view details request, we want the latest available readme information not necessary the latest available version is newer than the current version.
if (
'plugin-information' === fs_request_get( 'tab', false ) &&
$this->_fs->get_slug() === fs_request_get('plugin', false)
) {
$new_version = $this->get_latest_download_details( $is_addon ? $addon->id : false );
}
else
$new_version = $this->get_latest_download_details( $is_addon ? $addon->id : false, $plugin_version );

if ( ! is_object( $new_version ) || empty( $new_version->version ) ) {
$data->version = $plugin_version;
Expand Down