Next #415
Merged
Next #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded code and ARIA attributes.
…ses (#406) Implements container.formGroupClass parameter to pass or disable class different from form-group to containers
Drop popper as a direct dependency as it's now included in bootstrap bundle.
Use the the new `text-bg-*` classes instead of `bg-*` classes. https://getbootstrap.com/docs/5.3/components/badge/#background-colors
It makes is difficult for e.g. to put a submit and reset button together in the same column.
Update classes used by HtmlHelper::badge().
Update boostrap to v5.3 and bootstrap-icons to v1.11.
Don't wrap buttons with "elementWrapper" for inline forms.
Use "div" instead of "small" to avoid use of "d-block". Remove "text-muted" as "form-text" already applies the secondary color.
code cleanup
Simplify HTML for help text block.
It no longer exists in Bootstrap 5.
They don't exist in Bootstrap 5
Remove uneeded class on error message container
Remove undeeded code as the issue with ARIA attributes for `select` has been fixed in the core.
Defunct `form-*` classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for new minor targeting CakePHP 5.1.4+ and Bootstrap 5.3+.