Allow icon() to work with empty namespace and/or prefix#430
Merged
Conversation
Icon sets like Remixicon don't use a namespace class. Setting namespace to null or empty string previously resulted in extra spaces in the generated class attribute. This change makes both namespace and prefix optional: - Null/empty namespace is now properly omitted - Null/empty prefix uses just the icon name without a prefix Fixes #429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespaceoptional - null/empty values are now properly omitted instead of adding extra spacesprefixoptional - when null/empty, uses just the icon name without a prefix-dashThis allows using icon sets like Remixicon that don't use a namespace:
Also supports hypothetical icon sets using just the icon name:
Fixes #429