Adjust margin-bottom for paragraphs and list items#66
Open
zerosonesfun wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
Open
Adjust margin-bottom for paragraphs and list items#66zerosonesfun wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
zerosonesfun wants to merge 1 commit intoFriendsOfFlarum:2.xfrom
Conversation
Added negative margin-bottom to paragraphs and list items.
rafaucau
requested changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Thanks for the PR! Unfortunately, this doesn't fully resolve the issue — as you can see in the screenshot, there's now an unwanted scrollbar appearing.
I'd suggest a different approach: instead of using negative margins (which can cause side effects like this), try overriding the styles more cleanly — for example, reducing line-height and zeroing out the margins properly. Negative margin hacks tend to break layout in unexpected ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Added negative margin-bottom to paragraphs and list items. Due to Flarum's general LESS/CSS and how this extension works, pages end up with duplicate bottom margin for paragraphs and lists. By adding negative bottom margin, we reverse this. Now there is a normal amount of paragraph and list spacing for pages. This only targets pages; does not affect the rest of the forum.
Reviewers should focus on:
Installing this extension with and without the negative margin-bottom to see the difference.
Confirmed