-
Notifications
You must be signed in to change notification settings - Fork 308
Add CVE-2025-47964 for Symfony UX Twig/Live Component #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| title: "symfony/ux-live-component Unsanitized HTML attribute injection via ComponentAttributes" | ||
| link: https://symfony.com/blog/symfony-ux-cve-2025-47946-unsanitized-html-attribute-injection-via-componentattributes | ||
| cve: CVE-2025-47946 | ||
| branches: | ||
| 2.x: | ||
| time: 2025-05-19 12:05:00 | ||
| versions: ['<2.25.1'] | ||
| reference: composer://symfony/ux-live-component | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| title: "symfony/ux-twig-component Unsanitized HTML attribute injection via ComponentAttributes" | ||
| link: https://symfony.com/blog/symfony-ux-cve-2025-47946-unsanitized-html-attribute-injection-via-componentattributes | ||
| cve: CVE-2025-47946 | ||
| branches: | ||
| 2.x: | ||
| time: 2025-05-19 12:05:00 | ||
| versions: ['<2.25.1'] | ||
| reference: composer://symfony/ux-twig-component |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ux-live-component actually impacted directly or only through its dependency on ux-twig-component (which would be reported anyway through the other advisory) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say directly as attribute were created and rendered directly from ux-live-component... no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if you use symfony/ux-live-component 2.24 with symfony/ux-twig-component 2.25.1 ? Would we still have the security issue, or would be it solved by the patch in symfony/ux-twig-component 2.25.1 ? That's the main question here (if updating only symfony/ux-twig-component to 2.25.1 removes the security vulnerability, we don't need an advisory for symfony/ux-live-component).
The fact that symfony/ux-live-component might be buggy (due to some double-escaping in places where it was working around the TwigComponent vulnerability before) when installing it alongside the patched ux-twig-component is a different topic (as this is not about a security issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would crash in multiple LiveComponent places, as ComponentAttributes would not have its second required argument when instancied (in live compoonent code)