-
Notifications
You must be signed in to change notification settings - Fork 17
Code Assistent für Redakteur #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6f1e148
auto block manualy
skerbis a8a5bcc
Update boot.php
skerbis 428d00c
manualy fixed
skerbis 43d1676
placeholder styles
skerbis 51aa3b7
Update de_de.lang
skerbis af3d21b
Update editorial.php
skerbis 9643a28
admin info
skerbis e523bd9
panels nice
skerbis 4416c67
redakteurbereich und custom snippets
skerbis 837fc10
code style fixes
skerbis 41ba968
Editorial-Seite
skerbis 7832ae5
test
skerbis 395fdc1
consent secure fix
skerbis dbc22bd
HMAC Schutz
skerbis ad32e3c
HMAC revert
skerbis aa9d84c
youtube iframe fix
skerbis 54e4f94
security and code fix
skerbis 158c3e3
reihenfolge der seiten geändert.
skerbis d75c7c7
hilfeseiten zusammengeführt
skerbis 2fdb849
Update editorial.php
skerbis 0adfd50
update fix
skerbis 6047fad
regex fix
skerbis 71916bd
fixed issues reviewed by copilot
skerbis 28c7597
some security fixes from copilot issues
skerbis 22332d5
Bump version from 5.3.0-beta6 to 5.3.0-beta7
skerbis 28efc26
Update boot.php
skerbis 9698ba7
Merge branch 'autoblock_manualy' of https://github.com/FriendsOfREDAX…
skerbis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| # Auto-Blocking für manuell eingefügtes HTML | ||
|
|
||
| ## Übersicht | ||
|
|
||
| Das Inline-Consent-System kann jetzt automatisch Scripts, iframes und Divs erkennen und blocken, die mit speziellen `data-consent-*` Attributen versehen sind. | ||
|
|
||
| **✅ Neu in Version 5.3.0:** | ||
| - Automatisches Scannen und Blocken von externem Code | ||
| - Einfache Aktivierung über die Einstellungen | ||
| - Code-Assistent zum Vorbereiten von Scripts/iframes | ||
| - Keine PHP-Kenntnisse erforderlich | ||
|
|
||
| ## Aktivierung | ||
|
|
||
| ### 1. Auto-Blocking aktivieren | ||
|
|
||
| **Backend:** `Consent Manager → Einstellungen` | ||
|
|
||
| ✅ **Auto-Blocking für manuell eingefügtes HTML** aktivieren | ||
|
|
||
| ### 2. Code-Assistent nutzen (empfohlen) | ||
|
|
||
| **Direkt in den Einstellungen:** Button **"Code-Assistent öffnen"** klicken | ||
|
|
||
| Der interaktive Assistent öffnet sich als Modal und hilft beim Vorbereiten von externem Code: | ||
| 1. Original-Code einfügen | ||
| 2. Service aus Dropdown auswählen (oder eigenen eingeben) | ||
| 3. Optional: Anbieter, Datenschutz-URL, Titel, Platzhalter-Text | ||
| 4. **Code generieren** klicken | ||
| 5. Generierter Code kopieren und einfügen | ||
|
||
|
|
||
| **Hinweis:** Redakteure können nur aus bereits angelegten Services wählen. Admins können über "Eigenen Service-Schlüssel eingeben" auch neue Services verwenden (müssen diese aber später in den Einstellungen anlegen). | ||
|
|
||
| ## Manuelle Verwendung | ||
|
|
||
| ### 1. HTML mit data-consent-Attributen markieren | ||
|
|
||
| Fügen Sie folgende Attribute zu externen Scripts/iframes hinzu: | ||
|
|
||
| ```html | ||
| <iframe src="https://www.youtube.com/embed/VIDEO_ID" | ||
| width="560" height="315" | ||
| data-consent-block="true" | ||
| data-consent-service="youtube" | ||
| data-consent-provider="YouTube" | ||
| data-consent-privacy="https://policies.google.com/privacy" | ||
| data-consent-title="Video abspielen"></iframe> | ||
| ``` | ||
|
|
||
| ### 2. Pflicht-Attribute | ||
|
|
||
| - **`data-consent-block="true"`** - Aktiviert das Blocking (Pflicht) | ||
| - **`data-consent-service="servicekey"`** - Service-Schlüssel aus dem Consent Manager (Pflicht) | ||
|
|
||
| ### 3. Optionale Attribute | ||
|
|
||
| - **`data-consent-provider="Name"`** - Anbieter-Name (z.B. "YouTube") | ||
| - **`data-consent-privacy="URL"`** - Link zur Datenschutzerklärung | ||
| - **`data-consent-title="Titel"`** - Titel für den Placeholder | ||
| - **`data-consent-text="Text"`** - Individueller Platzhalter-Text (z.B. "Zur Buchung verwenden wir diesen Dienst. Bitte stimmen Sie zu.") | ||
|
|
||
| ### 4. Automatisches Scannen aktivieren | ||
|
|
||
| ~~Fügen Sie in Ihrem Template den Scanner hinzu:~~ **NICHT MEHR NÖTIG!** | ||
|
|
||
| Das Auto-Blocking wird automatisch aktiviert, sobald die Einstellung in `Consent Manager → Einstellungen` aktiviert ist. Kein Template-Code erforderlich! | ||
|
|
||
| ~~```php | ||
| <?php | ||
| // Am Ende des Templates, vor </body> | ||
| if (class_exists('\FriendsOfRedaxo\ConsentManager\InlineConsent')) { | ||
| // CSS/JS einbinden | ||
| echo \FriendsOfRedaxo\ConsentManager\InlineConsent::getCSS(); | ||
| echo \FriendsOfRedaxo\ConsentManager\InlineConsent::getJavaScript(); | ||
| } | ||
| ?> | ||
| ```~~ | ||
|
|
||
| ~~Und verwenden Sie den OUTPUT_FILTER zum automatischen Scannen:~~ **BEREITS INTEGRIERT!** | ||
|
|
||
| ~~```php | ||
| <?php | ||
| // In boot.php des Project-Addons oder im Template | ||
| rex_extension::register('OUTPUT_FILTER', function(rex_extension_point $ep) { | ||
| $content = $ep->getSubject(); | ||
|
|
||
| if (class_exists('\FriendsOfRedaxo\ConsentManager\InlineConsent')) { | ||
| $content = \FriendsOfRedaxo\ConsentManager\InlineConsent::scanAndReplaceConsentElements($content); | ||
| } | ||
|
|
||
| return $content; | ||
| }); | ||
| ?> | ||
| ```~~ | ||
|
|
||
| ✅ **Der OUTPUT_FILTER ist bereits in der boot.php integriert** - einfach in den Einstellungen aktivieren! | ||
|
|
||
| ## Beispiele | ||
|
|
||
| ### YouTube Video | ||
|
|
||
| ```html | ||
| <iframe src="https://www.youtube.com/embed/VIDEO_ID" | ||
| width="560" height="315" | ||
| data-consent-block="true" | ||
| data-consent-service="youtube" | ||
| data-consent-provider="YouTube" | ||
| data-consent-privacy="https://policies.google.com/privacy" | ||
| data-consent-title="Video abspielen"></iframe> | ||
| ``` | ||
|
|
||
| ### Calendly Widget | ||
|
|
||
| ```html | ||
| <div data-consent-block="true" | ||
| data-consent-service="calendly" | ||
| data-consent-provider="Calendly" | ||
| data-consent-privacy="https://calendly.com/privacy"> | ||
| <script src="https://assets.calendly.com/assets/external/widget.js"></script> | ||
| </div> | ||
| ``` | ||
|
|
||
| ### Custom iframe | ||
|
|
||
| ```html | ||
| <iframe src="https://example.com/widget" | ||
| width="100%" | ||
| height="500" | ||
| data-consent-block="true" | ||
| data-consent-service="custom-widget" | ||
| data-consent-provider="Example Inc." | ||
| data-consent-privacy="https://example.com/privacy" | ||
| data-consent-title="External Widget"></iframe> | ||
| ``` | ||
|
|
||
| ## Service im Consent Manager anlegen | ||
|
|
||
| Vergessen Sie nicht, den Service (z.B. "youtube") im Consent Manager zu konfigurieren: | ||
|
|
||
| 1. **Consent Manager → Cookies** | ||
| 2. **Neuen Cookie anlegen** | ||
| 3. **Service-Schlüssel:** `youtube` (muss mit `data-consent-service` übereinstimmen) | ||
| 4. **Service-Name:** YouTube | ||
| 5. **Cookie-Gruppe** zuweisen (z.B. "Marketing" oder "Externe Medien") | ||
|
|
||
| ## Vorteile | ||
|
|
||
| ✅ **Automatisch** - Kein manueller PHP-Code nötig | ||
| ✅ **Flexibel** - Funktioniert mit Scripts, iframes und Divs | ||
| ✅ **DSGVO-konform** - Inhalte werden erst nach Zustimmung geladen | ||
| ✅ **Benutzerfreundlich** - Klare Platzhalter mit Anbieter-Infos | ||
| ✅ **Einfach** - Nur Attribute im HTML hinzufügen | ||
|
|
||
| ## Technische Details | ||
|
|
||
| - Der Scanner läuft über einen OUTPUT_FILTER | ||
| - Regex-Pattern erkennt Tags mit `data-consent-block="true"` | ||
| - Tags werden durch `InlineConsent::doConsent()` Platzhalter ersetzt | ||
| - Original-Tags werden im Platzhalter gespeichert | ||
| - Nach Consent-Erteilung werden die Original-Tags geladen | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Doku sagt hier, dass der Code-Assistent „direkt in den Einstellungen“ per Button verfügbar ist. In der aktuellen
pages/config.php-Änderung wird aber nur das Checkbox-Setting hinzugefügt, ohne Modal/Button. Bitte Doku an die tatsächliche UI anpassen (z.B. auf die Editorial-Seite verweisen) oder den Assistant auch im Config-Screen implementieren.