fix(security): Add missing CSP nonce attributes to script tags in box_cssjs.php#460
Merged
fix(security): Add missing CSP nonce attributes to script tags in box_cssjs.php#460
Conversation
…_cssjs.php Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing nonce in box_cssjs.php
fix(security): Add missing CSP nonce attributes to script tags in box_cssjs.php
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical Content Security Policy (CSP) security issue by adding missing nonce attributes to 5 script tags in fragments/ConsentManager/box_cssjs.php. Without these nonces, strict CSP enforcement was being broken, potentially compromising the security policy of sites using this consent manager.
Changes:
- Added CSP nonce attributes to Google Consent Mode v2 script tag (line 57)
- Added CSP nonce attributes to debug mode scripts (lines 68, 71)
- Added CSP nonce attributes to consent manager configuration and frontend script tags (lines 167-168)
skerbis
added a commit
that referenced
this pull request
Feb 17, 2026
…_cssjs.php (#460) * Initial plan * fix(security): Add missing nonce attributes to all script tags in box_cssjs.php Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com>
skerbis
added a commit
that referenced
this pull request
Feb 17, 2026
* reload fixes (#457) * security fixes and theme preview * securit fix replace * Update CHANGELOG.md * 5.3.3 * namespace guide entfernt * fixed reload * Bump version to 5.3.4 and fix various issues Updated version to 5.3.4 and fixed multiple issues including JSON parsing errors, framework template loading, and security vulnerabilities. * 5.3.6 * alle laden inline via session erlauben * Fix iOS Safari touch events (thx @alexwenz) and update changelog * Address review comments: add missing translations and secure host usage * fix(security): Add missing CSP nonce attributes to script tags in box_cssjs.php (#460) * Initial plan * fix(security): Add missing nonce attributes to all script tags in box_cssjs.php Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> * rebuild form 5.3.5 * some inline fixes --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com>
skerbis
added a commit
that referenced
this pull request
Feb 17, 2026
* reload fixes (#457) * security fixes and theme preview * securit fix replace * Update CHANGELOG.md * 5.3.3 * namespace guide entfernt * fixed reload * Bump version to 5.3.4 and fix various issues Updated version to 5.3.4 and fixed multiple issues including JSON parsing errors, framework template loading, and security vulnerabilities. * 5.3.6 * alle laden inline via session erlauben * Fix iOS Safari touch events (thx @alexwenz) and update changelog * Address review comments: add missing translations and secure host usage * fix(security): Add missing CSP nonce attributes to script tags in box_cssjs.php (#460) * Initial plan * fix(security): Add missing nonce attributes to all script tags in box_cssjs.php Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com> * rebuild form 5.3.5 * some inline fixes * stylefixes removed some themes * Bump version from 5.5.0-dev to 5.5.0 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: skerbis <791247+skerbis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five script tags in
fragments/ConsentManager/box_cssjs.phpwere missing CSP nonce attributes, breaking strict Content Security Policy enforcement.Changes
Added
rex_response::getNonce()to:Before:
After:
Pattern matches 26+ existing nonce implementations across the codebase.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.