Enhance "copy-to-clipboard" buttons for non-SSL websites

[tyrant88]

etwas eleganter als mein Versuch von gestern.

Summary by CodeRabbit

• Refactor
  • Removed an unnecessary hidden section from the maintenance mode URL display.
  • Enhanced input field usability by linking them directly with their clipboard copy functionality.

[AWqxKAWERbXo]

Kopieren-Button funktioniert bereits einwandfrei mit Firefox, getestet mit 136.0 (64-Bit). Kann hier kein Problem reproduzieren.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The update modifies the HTML structure in the pages/frontend.php file by removing a hidden <div> that previously displayed the maintenance mode URL in a <code> tag. Unique id attributes have been added to the <input> elements for both the maintenance mode URL and YRewrite domain URLs, directly linking them to their clipboard copy functionality. This streamlines the HTML output and enhances clarity by eliminating unnecessary elements.

Changes

File	Summary
pages/.../frontend.php	Removed the hidden <div> with the <code> tag for the maintenance mode URL. Added id attributes to the <input> elements for both the maintenance mode URL and YRewrite domain URLs to enhance clipboard copy functionality.

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant Input as Input Field
    participant Clipboard as Clipboard Handler

    User->>Input: Click copy button
    Input->>Clipboard: Send URL data for copy
    Clipboard-->>Input: Confirm copy operation
    Input-->>User: Show copy confirmation

Loading

Possibly related PRs

• Enhance "copy-to-clipboard" buttons for non-SSL websites #139: The changes in the main PR are directly related to those in the retrieved PR, as both involve modifications to the same HTML elements and structure in the frontend.php file, specifically regarding the maintenance mode URL display and clipboard functionality.

Suggested labels

invalid

Suggested reviewers

• alxndr-w

Poem

In the land of code so neat,
I, the rabbit, hop to the beat.
Tidied HTML, smooth and sly,
No hidden divs to pass by.
Input fields now wear their IDs with pride,
Hop along; improvements reside!
🐰✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f61718f and a38a310.

📒 Files selected for processing (1)

• pages/frontend.php (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[crydotsnake]

Kopieren-Button funktioniert bereits einwandfrei mit Firefox, getestet mit 136.0 (64-Bit). Kann hier kein Problem reproduzieren.

Ein Screenshot der das Problem zeigt wäre gut gewesen.

[tyrant88]

Krass. Alles noch komplexer.
navigator.clipboard.writeText() braucht SSL.
Mit SSL geht es dann damit überall in jedem Browser.
Ohne SSL klappt es ohne das "hidden" Attribut auch.

Also mein PR macht es schon besser. Kann verstehen wenn du keine Lust hast eine nicht-SSL Zmgebung nur zum Verifizieren meiner Aussagen zu machen, aber dann wäre halt etwas Vertrauen angesagt.

Und dein neuer Freund der Code-Hase findet es ja auch gut.

[AWqxKAWERbXo]

Und dein neuer Freund der Code-Hase findet es ja auch gut.

(An dieser Stelle bitte den lauten Seufzen vorstellen wie den Seufzer, den du am REDAXO-Tag zum Thema AI in meine Richtung losgelassen hast. Danke, bitte.)

Ich muss ganz ehrlich fragen: Wer hat heutzutage eigentlich nicht lokal SSL am laufen?

Man kann sich auch seine eigenen Probleme schaffen oder muss damit leben, dass Browser eben Browser-Dinge tun. Auch der jetzt kommerzig-schnüfflige Firefox.

Also mein PR macht es schon besser.

Danke für die Klärung und Nachforschung.

aber dann wäre halt etwas Vertrauen angesagt.

Fool me once, shame on you. Fool me twice, shame on me.