Skip to content

fix: Skip sql_set_default_session_variables for Shopware >= 6.7 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schneider-felix merged 1 commit into from
Aug 5, 2025
Merged

fix: Skip sql_set_default_session_variables for Shopware >= 6.7 #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Components/Health/Checker/PerformanceChecker/MysqlSettingsChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Frosh\Tools\Components\Health\HealthCollection;
use Frosh\Tools\Components\Health\SettingsResult;
use Shopware\Core\DevOps\Environment\EnvironmentHelper;
use Symfony\Component\DependencyInjection\Attribute\Autowire;

class MysqlSettingsChecker implements PerformanceCheckerInterface, CheckerInterface
{
Expand All @@ -23,8 +24,11 @@ class MysqlSettingsChecker implements PerformanceCheckerInterface, CheckerInterf
'UTC',
];

public function __construct(private readonly Connection $connection)
{
public function __construct(
private readonly Connection $connection,
#[Autowire(param: 'kernel.shopware_version')]
private readonly string $shopwareVersion,
) {
}

public function collect(HealthCollection $collection): void
Expand Down Expand Up @@ -86,6 +90,11 @@ private function checkTimeZone(HealthCollection $collection): void

private function checkCheckDefaultEnvironmentSessionVariables(HealthCollection $collection): void
{
// https://github.com/shopware/shopware/commit/c0a162f11852130b34e7c725bd7429aeb89a7b75
if (\version_compare($this->shopwareVersion, '6.7.0', '>=')) {
return;
}

$setSessionVariables = (bool) EnvironmentHelper::getVariable('SQL_SET_DEFAULT_SESSION_VARIABLES', true);
if ($setSessionVariables) {
$collection->add(
Expand Down
Loading