Skip to content

Conversation

@shyim
Copy link
Member

@shyim shyim commented Aug 15, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to allow skipping specific health checks by introducing a configuration option for disabled checks. The changes enable users to configure which health checks should be excluded from the status endpoints.

  • Adds a new configuration parameter frosh_tools.checker.disabled_checks to store an array of check IDs to skip
  • Implements filtering logic in the HealthController to remove disabled checks from both status and performance endpoints
  • Modifies the SettingsResult class to expose the ID property and adds a removeByIds method to HealthCollection

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/DependencyInjection/FroshToolsExtension.php Replaces system_config parameter with checker.disabled_checks parameter
src/DependencyInjection/Configuration.php Adds configuration tree for checker.disabled_checks array
src/Controller/HealthController.php Injects disabled checks parameter and filters collections in both endpoints
src/Components/Health/SettingsResult.php Changes id property visibility from protected to public
src/Components/Health/HealthCollection.php Adds removeByIds method to filter out disabled checks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@schneider-felix schneider-felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I like it. I think it would be awesome if you could also "ignore" checks from the administration. We could simply write the ids of the ignored checks to system_config. What do you think?

@shyim
Copy link
Member Author

shyim commented Aug 18, 2025

@frosh-automation create-instance

@frosh-automation
Copy link
Contributor

Hey 👋,

I have created for you an Shopware Instalation with the current changes made here.

You can access the Shop here: https://tj5ki2o-57l3qknm5v8b0.zrh2.namespaced.app

The URL is only for FriendsOfShopware members.

@shyim shyim merged commit 46cb187 into main Aug 18, 2025
4 checks passed
@shyim shyim deleted the feat/allow-skipping-checks branch August 18, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants