-
Notifications
You must be signed in to change notification settings - Fork 34
feat: allow skipping checks #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to allow skipping specific health checks by introducing a configuration option for disabled checks. The changes enable users to configure which health checks should be excluded from the status endpoints.
- Adds a new configuration parameter
frosh_tools.checker.disabled_checksto store an array of check IDs to skip - Implements filtering logic in the HealthController to remove disabled checks from both status and performance endpoints
- Modifies the SettingsResult class to expose the ID property and adds a removeByIds method to HealthCollection
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DependencyInjection/FroshToolsExtension.php | Replaces system_config parameter with checker.disabled_checks parameter |
| src/DependencyInjection/Configuration.php | Adds configuration tree for checker.disabled_checks array |
| src/Controller/HealthController.php | Injects disabled checks parameter and filters collections in both endpoints |
| src/Components/Health/SettingsResult.php | Changes id property visibility from protected to public |
| src/Components/Health/HealthCollection.php | Adds removeByIds method to filter out disabled checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
schneider-felix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I like it. I think it would be awesome if you could also "ignore" checks from the administration. We could simply write the ids of the ignored checks to system_config. What do you think?
|
@frosh-automation create-instance |
|
Hey 👋, I have created for you an Shopware Instalation with the current changes made here. You can access the Shop here: https://tj5ki2o-57l3qknm5v8b0.zrh2.namespaced.app The URL is only for FriendsOfShopware members. |
No description provided.