-
Notifications
You must be signed in to change notification settings - Fork 83
✨(feat) Migrate to CKEditor 5 + allow back Php7.4 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
|
Related issue: #242 |
|
@floviolleau Thanks for working on this. Could you please resolve the conflicts and give us an update of your plans (remaining tasks) ? |
|
Hi @Chris53897, I fixed the conflicts. The remaining tasks are in the first message and still pending. I have a basic usage of ckeditor5 so for now I didn't implemented plugins and other stuffs. My PR is still pending since last year, nobody maintain this project so I implement what I need for now :). Feel free to enhance my MR. I made #272 for php8 |
|
This PR really scares me regarding #242 (comment) Would it be possible to make ckeditor5 optional? |
|
Hi, Ckeditor is OK if your are on GPL. Make ckeditor5 optional is some work because logic to retrieve and do configuration is different as well the rendering. I will think about it but it can be better if the maintainer is still here to guide developments and at least approve PR |
Hi,
This is a full rewrite to make it working with ckeditor 5.
Because I still use Symfony 5.4 and Php 7.4, I allowed to install with Php 7.4
Here is an example of configuration:
Remaining tasks: