drop the x- prefix from our custom headers

[dbu]

fix #279

rfc6648 says to not prefix custom headers with x-. this PR removes all x- prefixes from default header names we use in this library.

X-Symfony-Cache is done by symfony, not by us.

Question: Is this a good idea and makes the library cleaner, or a pedantic change that is an unnecessary BC break and leads to tons of confusion? Upgrading applications have to also change all their VCL or nginx configuration or will end with broken systems.

[dbu]

@ddeboer seems i missed to adjust something, but what do you think in general, do we want to do this? i notice that i kind of like a prefix to see which headers are standard and which are done by us... but the rfc seems to say we should do it like this.

[dbu]

@ddeboer ping

[dbu]

ping @ddeboer

[TomasVotruba]

Looks fine! Would that be a BC break, so aiming for next mayor release?

[dbu]

@TomasVotruba yes, this is a PR against master which will be 2.0. current stable versions are 1.x

[TomasVotruba]

Allright then

[dbu]

may i ask you for your opinion @Tobion @lsmith77 ?

Question: Is this a good idea and makes the library cleaner, or a pedantic change that is an unnecessary BC break and leads to tons of confusion? Upgrading applications have to also change all their VCL or nginx configuration or will end with broken systems.

[lsmith77]

In general the RFC to deprecate "-X" prefix makes it clear that they talk about "new standards"
https://tools.ietf.org/html/rfc6648

ie. they do not say that existing (defacto) standards need to be updated but just that when defining new standards one should avoid the "-x" prefix.

So I would say its not necessary to push people away from "-x" in currently working scenarios.

[dbu]

@lsmith77 thanks for this input. i think the discussion started when we discussed why our prefixes are X- and not something like FOS- . but at that point, i think i will simply drop this. i committed the very few general cleanups that where included in this PR to master.