Skip to content

Conversation

@jdreesen
Copy link
Contributor

It would be great if you could configure the third parameter of the \FOS\HttpCache\ProxyClient\HttpProxyClient without having to overwrite the entire service.

@jdreesen jdreesen force-pushed the feat/configure-proxy-client-request-factory branch from a8c4e27 to d1601f2 Compare June 16, 2025 16:35
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, seems a reasonable idea to have this.

can you please add this to the documentation as well so the option is explained? and a note in the changelog would be nice.

and if you have time to add a test that ensures the factory is actually configured when specified in the config, that would be nice too.

@jdreesen
Copy link
Contributor Author

can you please add this to the documentation as well so the option is explained? and a note in the changelog would be nice

Will do that.

(also for the tweak with the ProxyClient alias :-) ) the version will be 3.2.0

Please note that this PR targets 2.x (because we're currently stuck with Symfony 5 😞 for the other PR I forgot to select 2.x as the target 🤦, but this one is more important for us).

and if you have time to add a test that ensures the factory is actually configured when specified in the config, that would be nice too.

I'll look into it.

@dbu
Copy link
Contributor

dbu commented Jun 17, 2025

oh, i did not realize this goes to 2.x

alright, i can do a new minor of 2.x for this to help you out. i will wait until you added the doc, changelog and if you manage to add a test.
for the proxyclient i added the changelog entry meanwhile.

@dbu dbu merged commit 40a2451 into FriendsOfSymfony:2.x Jun 17, 2025
10 of 11 checks passed
@dbu
Copy link
Contributor

dbu commented Jun 17, 2025

there you go https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.18.0

thanks for the contributions!

@jdreesen jdreesen deleted the feat/configure-proxy-client-request-factory branch June 17, 2025 13:18
@jdreesen
Copy link
Contributor Author

Wow, that was fast! Thank you very much 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants