-
Notifications
You must be signed in to change notification settings - Fork 84
Add support for configurable HTTP request factory for proxy clients #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configurable HTTP request factory for proxy clients #646
Conversation
a8c4e27 to
d1601f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, seems a reasonable idea to have this.
can you please add this to the documentation as well so the option is explained? and a note in the changelog would be nice.
and if you have time to add a test that ensures the factory is actually configured when specified in the config, that would be nice too.
Will do that.
Please note that this PR targets
I'll look into it. |
|
oh, i did not realize this goes to 2.x alright, i can do a new minor of 2.x for this to help you out. i will wait until you added the doc, changelog and if you manage to add a test. |
Co-authored-by: David Buchmann <[email protected]>
|
there you go https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.18.0 thanks for the contributions! |
|
Wow, that was fast! Thank you very much 💚 |
It would be great if you could configure the third parameter of the
\FOS\HttpCache\ProxyClient\HttpProxyClientwithout having to overwrite the entire service.