~ fixed refactored behavior in AuthorizedFormHandler

dinamic · dkarlovi · commit b594679e3f17 · 2018-01-15T08:48:37.000+01:00
diff --git a/Form/Handler/AuthorizeFormHandler.php b/Form/Handler/AuthorizeFormHandler.php
@@ -72,7 +72,7 @@ public function isRejected()
     }
 
     /**
-     * @return bool|void
+     * @return bool
      */
     public function process()
     {
@@ -93,7 +93,7 @@ public function process()
 
         $this->form->handleRequest($request);
         if (!$this->form->isValid()) {
-            return;
+            return false;
         }
 
         $this->onSuccess();
diff --git a/Tests/Form/Handler/AuthorizeFormHandlerTest.php b/Tests/Form/Handler/AuthorizeFormHandlerTest.php
@@ -376,7 +376,7 @@ public function testProcessWillHandleRequestOnPost()
             ->willReturn(false)
         ;
 
-        $this->assertNull($this->instance->process());
+        $this->assertFalse($this->instance->process());
     }
 
     public function testProcessWillHandleRequestOnPostAndWillProcessDataIfFormIsValid()

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public function isRejected()`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`/**`
`75`		`- * @return bool\|void`
	`75`	`+ * @return bool`
`76`	`76`	`*/`
`77`	`77`	`public function process()`
`78`	`78`	`{`
`@@ -93,7 +93,7 @@ public function process()`
`93`	`93`
`94`	`94`	`$this->form->handleRequest($request);`
`95`	`95`	`if (!$this->form->isValid()) {`
`96`		`- return;`
	`96`	`+ return false;`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`$this->onSuccess();`
Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ public function testProcessWillHandleRequestOnPost()`
`376`	`376`	`->willReturn(false)`
`377`	`377`	`;`
`378`	`378`
`379`		`- $this->assertNull($this->instance->process());`
	`379`	`+ $this->assertFalse($this->instance->process());`
`380`	`380`	`}`
`381`	`381`
`382`	`382`	`public function testProcessWillHandleRequestOnPostAndWillProcessDataIfFormIsValid()`