Skip to content

Fix return type of Connection::execute#146

Open
benjaminfayaz wants to merge 2 commits intoFriendsOfSymfony1:masterfrom
alphabrik:fix-stmnt-type
Open

Fix return type of Connection::execute#146
benjaminfayaz wants to merge 2 commits intoFriendsOfSymfony1:masterfrom
alphabrik:fix-stmnt-type

Conversation

@benjaminfayaz
Copy link

No description provided.

@t-gebauer
Copy link

Related: #114

@thePanz
Copy link
Member

thePanz commented Apr 30, 2025

thanks @benjaminfayaz for this fix!
According to Connection::prepare($statement) the return could also be void in case of an Doctrine_Adapter_Exception or PDOException.

That should be added too IMO, WDYT?

The same applies for Connection::execute(), as its last line $this->rethrowException(...) might not re-throw the exception and return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants