[QA] added phpstan dist config#312
[QA] added phpstan dist config#312connorhu wants to merge 18 commits intoFriendsOfSymfony1:masterfrom
Conversation
46c3964 to
2711edd
Compare
|
@connorhu I added something like this to exclude files not relevant for phpstan |
ffb5e24 to
a347c93
Compare
|
@thePanz Thank you! Updated the config. Should we do the same as doctrine1? (php7.4 and php8.3 simultan tests) |
| { | ||
| } | ||
|
|
||
| include 'PEAR/REST/10.php'; |
There was a problem hiding this comment.
🙈 why do we need PEAR?! 🙈
Should we completely drop it? @thirsch IIRC you mentioned something like this?
There was a problem hiding this comment.
plugin uses this. i would drop it too as you can see in my plugin loading improvement issue #342 . if only because the default symfony channels don't work. refer to propel discussion
composer.json
Outdated
| "require-dev": { | ||
| "psr/log": "*" | ||
| "psr/log": "*", | ||
| "friendsofsymfony1/doctrine1": "*" |
There was a problem hiding this comment.
should we define the min-versions here?
should swiftmailer be added too?
There was a problem hiding this comment.
Swiftmailer is in required section.
What is the min version should be?
There was a problem hiding this comment.
Swiftmailer is in required section
🙈 true 😅
Does it mean that we can remove the GIT submodules then?
What is the min version should be?
I would pick the latest tagged one IMO
There was a problem hiding this comment.
The expert on submodule removal is @thirsch . Paging dr @thirsch
#302 (comment)
25bb848 to
7cc334d
Compare
No description provided.