[TASK] Use dependency injection in commands#69
Merged
xperseguers merged 1 commit intoFriendsOfTYPO3:mainfrom Nov 11, 2025
Merged
[TASK] Use dependency injection in commands#69xperseguers merged 1 commit intoFriendsOfTYPO3:mainfrom
xperseguers merged 1 commit intoFriendsOfTYPO3:mainfrom
Conversation
Contributor
Author
|
Waiting for #67 to be merged. |
Contributor
|
Is this still considered WIP or shall we merge it? |
Contributor
Author
|
Will work on it again on autumn. The next weeks I have other priorities and then vacation. |
brotkrueml
force-pushed
the
use-di-in-commands
branch
3 times, most recently
from
455a22b to
0dc9a51
Compare
Injecting an instance of the Setup class in the commands allows us to add tests for those commands. The tests just check if the right Setup method is called and the output is correct.
brotkrueml
force-pushed
the
use-di-in-commands
branch
from
0dc9a51 to
208ea05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injecting an instance of the Setup class in the commands allows us to add tests for those commands. The tests just check if the right Setup method is called and the output is correct.